fix: resolve InContext Sidebar post menu dropdown clipping that triggered scroll #1
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the InContext Sidebar post menu dropdown was being clipped and causing unwanted scrolling in the sidebar container. The solution involves applying specific CSS positioning to the dropdown when rendered within the in-context sidebar.
- Added conditional CSS class application to the ActionsDropdown component based on URL parameter detection
- Implemented CSS styling with fixed positioning and increased z-index for the in-context sidebar dropdown
- Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/index.scss | Added CSS rules for fixed positioning of dropdown in in-context sidebar mode |
| src/discussions/common/ActionsDropdown.jsx | Added logic to detect in-context sidebar mode and conditionally apply CSS class |
| src/discussions/common/ActionsDropdown.test.jsx | Added test coverage for in-context sidebar detection and CSS class application |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| .actions-dropdown.in-context-sidebar { | ||
| position: fixed !important; | ||
| z-index: 10 !important; | ||
| } |
There was a problem hiding this comment.
Using !important declarations should be avoided as they make CSS harder to maintain and override. Consider using more specific selectors or restructuring the CSS hierarchy to achieve the desired specificity without !important.
Copilot uses AI. Check for mistakes.
Description
Fixes the issue where the InContext Sidebar post menu dropdown was being forcefully contained within the sidebar container.
This caused the dropdown to be clipped and introduced an unwanted scroll in the sidebar.
Jira Ticket: LP-85
How Has This Been Tested?
Screenshots
Before : Dropdown clipped and causing scroll
After : Dropdown fixed without scroll