fix(test): unifiy test for RF<4 and RF>=4 #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tattoo
requested changes
Sep 8, 2021
Comment on lines
58
to
62
| exampleTree = ElementTree.parse(example) | ||
| exampleRoot = exampleTree.getroot() | ||
|
|
||
| actualTree = ElementTree.parse(actual) | ||
| actualRoot = actualTree.getroot() |
There was a problem hiding this comment.
I propose we do not introduce variables when they are not used:
Suggested change
| exampleTree = ElementTree.parse(example) | |
| exampleRoot = exampleTree.getroot() | |
| actualTree = ElementTree.parse(actual) | |
| actualRoot = actualTree.getroot() | |
| example_xml = ElementTree.parse(example).getroot() | |
| produced_xml = ElementTree.parse(actual).getroot() |
Comment on lines
66
to
68
| exampleStat = exampleRoot.find( | ||
| './statistics/total//stat[.="All Tests"]') | ||
| actualStat = actualRoot.find('./statistics/total//stat[.="All Tests"]') |
There was a problem hiding this comment.
Let's not repeat the XPath pattern as it's the same for both:
Suggested change
| exampleStat = exampleRoot.find( | |
| './statistics/total//stat[.="All Tests"]') | |
| actualStat = actualRoot.find('./statistics/total//stat[.="All Tests"]') | |
| all_tests_stat_block = './statistics/total//stat[.="All Tests"]' | |
| expected_stat = exampleRoot.find(all_tests_stat_block) | |
| actual_stat = actualRoot.find(all_tests_stat_block) |
Also, I think most of the project, we use snake_case rather than camelCase. unittest's asserts are the exception, which is supremely annoying 😠
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.