Skip to content

fix: lock socket.io to v2.0.1 fix the error #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 8, 2017
Merged

fix: lock socket.io to v2.0.1 fix the error #17

merged 3 commits into from
Jun 8, 2017

Conversation

ngot
Copy link
Member

@ngot ngot commented Jun 8, 2017

No description provided.

"egg-bin": "^2.0.2",
"egg-socket.io": "^1.0.0-beta.1",
"socket.io-client": "^1.7.2"
"egg": "^1.4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么 egg 在 dependencies 里面?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好吧,example,不过下面的 egg-bin 还是错了

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我挪一下

@codecov
Copy link

codecov bot commented Jun 8, 2017

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #17   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     11           
  Lines         151    151           
=====================================
  Hits          151    151

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e9f3c3...ad8cbb1. Read the comment docs.

@dead-horse dead-horse merged commit 04a5b7c into master Jun 8, 2017
@dead-horse dead-horse deleted the lock branch June 8, 2017 16:57
@dead-horse
Copy link
Member

@ngot 发个版本吧

@atian25
Copy link
Member

atian25 commented Jun 12, 2017

这个发版本了么?

@ngot
Copy link
Member Author

ngot commented Jun 12, 2017

刚刚发了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants