Move PID look up tables into global pid_lut file

[simonge]

Briefly, what does this PR introduce?

Moves all of the PID LUT factories out of their detector plugin into the global pid plugin. Also moves PID factory files into the factories directory.

Maybe a matter of personal taste but this would make the data flow through the PID algorithms more transparent.

What kind of change does this PR introduce?

• Bug fix (issue #__)
• New feature (issue #__)
• Documentation update
• Other: Refactoring

Please check if this PR fulfills the following:

• Tests for the changes have been added
• Documentation has been added / updated
• Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

[veprbl]

This should be fine to do.

[github-actions]

Capybara summary for PR 1745

• rec_dis_10x100_minQ2=0_craterlake
• rec_dis_10x100_minQ2=1000_craterlake_tracking_only
• rec_dis_18x275_minQ2=0_craterlake_18x275
• rec_dis_18x275_minQ2=1000_craterlake_18x275
• rec_dis_5x41_minQ2=0_craterlake_5x41
• rec_e_1GeV_20GeV_craterlake
• rec_pi_1GeV_20GeV_craterlake
  ^{_{Last updated 2025-06-02T15:26-04:00 4fbd028}}

[wdconinc]

What's the plan for this PR? Since the conflicts are likely due to the clang-format or clang-tidy PR, I can offer to resolve them, but only if there's a plan to merge this.

[simonge]

I still think it makes the data flow clearer. I will resolve the conflicts myself but might add another intermediate PR to move all of the remaining factories out of src/global into src/factories.

[wdconinc]

Hmm... is GitHub confused about e2dfefd, or did something go wrong in the update/rebase? I see the entire repository reformat in this PR again.

[simonge]

Hmm... is GitHub confused about e2dfefd, or did something go wrong in the update/rebase? I see the entire repository reformat in this PR again.

Something probably went wrong with the rebase. I have to admit I haven't quite got my head around how to rebase/merge safely, I think this happened because I earlier merged origin/main and now have tried to rebase.

[simonge]

It's not a lot of work so I can just create a new clean branch and PR to avoid the mess. Unless you have a better idea.

[wdconinc]

It's not a lot of work so I can just create a new clean branch and PR to avoid the mess. Unless you have a better idea.

If it's just the first 3 commits (?), you could possibly run something like:

git reset --hard origin/main
git cherry-pick sha1
git cherry-pick sha2
git cherry-pick sha3
git push --force

There will be conflicts, but hopefully manageable.

[simonge]

Thanks, hopefully that's much better

[wdconinc]

Looks good to me. Waiting for diffs.

[simonge]

Should I ignore iwyu asking for both:

#include <JANA/JApplication.h>
#include <JANA/JApplicationFwd.h>

I'll wait for the diffs before drawing conclusions about the tests and benchmarks not using the right libraries

[wdconinc]

Should I ignore iwyu asking for both:

#include <JANA/JApplication.h>
#include <JANA/JApplicationFwd.h>

I looked into this only briefly, but I think iwyu is correct here in suggesting that both should be included. The JApplicationFwd.h is an incomplete forwarding header, so some things need JApplication.h as well.

[wdconinc]

I'll wait for the diffs before drawing conclusions about the tests and benchmarks not using the right libraries

Diff looks good.