Skip to content

feat: determine detector checksum on geometry read (if supported) #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Apr 8, 2025

Briefly, what does this PR introduce?

This PR adds geometry checksum determination on geometry read. At this point there is no comparison to the detector checksum used on simulation input determination, but it's a start and a proof of concept.

Needs:

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators @veprbl

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

Copy link
Contributor

github-actions bot commented Apr 8, 2025

@wdconinc wdconinc force-pushed the geometry-checksum branch from ca5ca27 to 0006464 Compare April 9, 2025 14:47
@wdconinc wdconinc force-pushed the geometry-checksum branch from 0006464 to c711df5 Compare April 12, 2025 23:40
@wdconinc wdconinc force-pushed the geometry-checksum branch 2 times, most recently from bab1007 to 27e93ad Compare April 25, 2025 18:40
@wdconinc wdconinc force-pushed the geometry-checksum branch from f38cd9e to d82ee45 Compare May 6, 2025 02:45
@wdconinc wdconinc force-pushed the geometry-checksum branch from d82ee45 to 601c402 Compare May 8, 2025 04:02
@wdconinc wdconinc force-pushed the geometry-checksum branch from 601c402 to 2fc2262 Compare May 9, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant