feat: log error with algorithm exception before throwing to JANA #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Without log duplicate filter: |
Capybara summary for PR 1790
|
wdconinc
force-pushed
the
log-error-on-algorithm-exception
branch
from
968eef2 to
32552fb
Compare
wdconinc
force-pushed
the
log-error-on-algorithm-exception
branch
from
32552fb to
2edd225
Compare
wdconinc
force-pushed
the
log-error-on-algorithm-exception
branch
from
2edd225 to
63eba8f
Compare
|
This should now already produce a lot fewer false positives. At least for DIS. There's still the OMD which is only defined properly for 130 GeV protons, which we never simulate... |
wdconinc
force-pushed
the
log-error-on-algorithm-exception
branch
from
63eba8f to
58f5e0d
Compare
wdconinc
force-pushed
the
log-error-on-algorithm-exception
branch
from
58f5e0d to
68e717d
Compare
wdconinc
force-pushed
the
log-error-on-algorithm-exception
branch
from
68e717d to
72022b7
Compare
wdconinc
force-pushed
the
log-error-on-algorithm-exception
branch
from
72022b7 to
e9d5073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR adds printing of exceptions from algorithms to the log stream as errors. Likely to be useful with #1789 since it would otherwise be overwhelming. This will help avoid issues like #1762 (comment), #1788, and #1795.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
Yes, prints exceptions. Likely a lot for simulation input that does not contain default collections.