Skip to content

feat: run ClangBuildAnalyzer on builds #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented May 7, 2025

Briefly, what does this PR introduce?

This PR adds build diagnostics. Leaner code and faster builds result in better CI pipeline throughput.

Needs:

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc wdconinc force-pushed the clang-build-analyzer branch 2 times, most recently from ffc4064 to 0b9c99d Compare May 8, 2025 21:40
@wdconinc
Copy link
Contributor Author

wdconinc commented May 9, 2025

Finally works, https://github.com/eic/EICrecon/actions/runs/14918402972/job/41908936816?pr=1854#step:8:242

**** Expensive headers:
153312 ms: /opt/local/include/JANA/JApplication.h (included 70 times, avg 2190 ms), included via:
  51x: <direct include>
  2x: JEvent.h JObject.h JFactoryT.h 
  1x: TrackingTest_processor.h 
  1x: eicrecon_cli.h 
  1x: TrackingEfficiency_processor.h 
  1x: DumpFlags_processor.h 
  ...

124661 ms: /opt/local/include/DD4hep/Detector.h (included 78 times, avg 1598 ms), included via:
  18x: <direct include>
  8x: CalorimeterClusterRecoCoG_factory.h AlgorithmsInit_service.h geo.h CellIDPositionConverter.h 
  7x: SiliconTrackerDigi_factory.h AlgorithmsInit_service.h geo.h CellIDPositionConverter.h 
  3x: geo.h CellIDPositionConverter.h 
  2x: ACTSGeo_service.h 
  2x: SubDivideFunctors.h geo.h CellIDPositionConverter.h 
  ...

60751 ms: /opt/local/include/algorithms/logger.h (included 99 times, avg 613 ms), included via:
  11x: geo.h 
  9x: CalorimeterClusterRecoCoG_factory.h CalorimeterClusterRecoCoG.h algorithm.h 
  7x: SiliconTrackerDigi_factory.h SiliconTrackerDigi.h algorithm.h 
  3x: <direct include>
  2x: SubDivideFunctors.h geo.h 
  2x: SiliconPulseGeneration.h algorithm.h 
  ...

53396 ms: /opt/local/include/algorithms/service.h (included 101 times, avg 528 ms), included via:
  11x: geo.h logger.h 
  9x: CalorimeterClusterRecoCoG_factory.h CalorimeterClusterRecoCoG.h algorithm.h logger.h 
  7x: SiliconTrackerDigi_factory.h SiliconTrackerDigi.h algorithm.h logger.h 
  3x: <direct include>
  3x: logger.h 
  2x: SubDivideFunctors.h geo.h logger.h 
  ...

Copy link
Contributor

github-actions bot commented May 9, 2025

@wdconinc wdconinc force-pushed the clang-build-analyzer branch from 147db7b to 63ce949 Compare May 9, 2025 13:33
@wdconinc wdconinc requested a review from veprbl May 9, 2025 13:33
@wdconinc wdconinc enabled auto-merge May 10, 2025 15:40
@wdconinc wdconinc force-pushed the clang-build-analyzer branch from 63ce949 to 2730207 Compare May 12, 2025 04:10
@wdconinc wdconinc force-pushed the clang-build-analyzer branch from 2730207 to e011eb3 Compare May 23, 2025 00:31
@wdconinc wdconinc force-pushed the clang-build-analyzer branch from e011eb3 to ef70281 Compare May 29, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant