Add configuration option to output clones from subdivided and collected collections #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capybara summary for PR 1861
|
|
I suppose this could be dangerous/cause confusion if used on some intermediate collections and mess up all of the associations. |
|
I don't know if I like this. There are suitable interfaces to podio for all analysis languages (or, if not, they can be developed). This duplicates storage needs for convenience reasons only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Adds the
output_copiesconfiguration to tell theCollectionCollectorandSubDivideCollectionalgorithms to copy the data into the output rather than produce a subset collection.This will allow, for instance, the merging of particles from the central detector and far detectors into a final collection, with the final collection being directly readable in a root tree. Or wanting to examine the contents of the collection in a root tree for debugging.
e.g.
-Pbeam:BeamParticles:outputCopies=trueWhat kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No, but perhaps an example collection should be chosen