feat: add requireMatchingMatrix option; disable for OFFM in CI #1862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: far-forward
Capybara summary for PR 1862
|
wdconinc
force-pushed
the
matrix-transfer-static--offm-require-matching-matrix-false
branch
from
c32bc30 to
eb6501d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
wdconinc
force-pushed
the
matrix-transfer-static--offm-require-matching-matrix-false
branch
from
eb6501d to
9a94aa6
Compare
simonge
approved these changes
Jun 2, 2025
wdconinc
deleted the
matrix-transfer-static--offm-require-matching-matrix-false
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR adds a new option
requireMatchingMatrixto the MatrixTransferStatic algorithm, to allow disabling the check for a valid matrix. This allows disabling (in CI) the off-momentum tracker errors for every event.Similar to #1716.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.