Cabal doctest #33
Cabal doctest #33
Conversation
phadej
force-pushed
the
cabal-doctest
branch
5 times, most recently
from
ec9e853 to
caed9ca
Compare
There was a problem hiding this comment.
Yay yay yay! Thanks a bunch for doing this, @phadej!
I've left some comments inline.
| filepath >= 1.3.0.0 | ||
| base >= 4.5 && <5, | ||
| Cabal >= 1.14, | ||
| cabal-doctest >= 1 && <1.1 |
There was a problem hiding this comment.
How does the test-doctests flag interact with this feature? That is, if someone configured this project with -f-test-doctests, would custom-setup also be disabled? (I don't think it's a dealbreaker if we can't make it do that, but I am curious.)
There was a problem hiding this comment.
IIRC it was a design decision that custom-setup section doesn't support flags / conditionals. But I'm not sure. I'll check.
Setup.lhs
Outdated
| { buildHook = \pkg lbi hooks flags -> do | ||
| generateBuildModule "doctests" flags pkg lbi | ||
| buildHook simpleUserHooks pkg lbi hooks flags | ||
| } |
There was a problem hiding this comment.
This is a little wordier than I would have expected. Couldn't we export something like this from cabal-doctest:
doctestsUserHooks :: UserHooks
doctestsUserHooks testsuiteName = simpleUserHooks
{ buildHook = \pkg lbi hooks flags -> do
generateBuildModule testsuiteName flags pkg lbi
buildHook simpleUserHooks pkg lbi hooks flags
}And then just do main = defaultMainWithHooks $ doctestUserHooks "doctests"? There's far less boilerplate involved on the commonly taken path (modern Cabal) this way, and you can still override the fields of doctestUserHooks "doctests" if you wish.
There was a problem hiding this comment.
Yeah, just thought about this omw home. Maybe even also defaultMainWithDoctests
|
@RyanGlScott could you take another look. If it's ok, I'll release |
|
@phadej, looks great! Please go ahead and upload it to Hackage. |
cc @RyanGlScott