Skip to content

fix(async_hooks): properly update sync flag #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2019
Merged

fix(async_hooks): properly update sync flag #1306

merged 1 commit into from
Aug 23, 2019

Conversation

Qard
Copy link
Contributor

@Qard Qard commented Aug 22, 2019 •
edited by zube bot
Loading

This fixes an issue discovered in #1298 due to changing the test/_agent.js file to use a real config object rather than a mock, which exposed that the mock would implicitly have asyncHooks: false in its settings by omission.

Checklist

  • Implement code
  • Add tests

@Qard Qard requested a review from watson August 22, 2019 23:42
@Qard Qard self-assigned this Aug 22, 2019
watson
watson approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 💯

@watson watson merged commit aad2e77 into elastic:master Aug 23, 2019
@Qard Qard deleted the fix-sync-flag-with-async-hooks branch August 23, 2019 17:06
@SimonSimCity SimonSimCity mentioned this pull request Sep 11, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@watson watson watson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Qard Qard

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qard @watson