Skip to content

Conversation

trentm
Copy link
Member

@trentm trentm commented Oct 18, 2022

Node v19.0.0 is out today: https://twitter.com/nodejs/status/1582401871179747329
Update our tested node.js versions to include it.
We already have 19 in package.json "engines".

@trentm trentm self-assigned this Oct 18, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Oct 18, 2022
@ghost
Copy link

ghost commented Oct 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-20T16:12:28.818+0000

  • Duration: 113 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 321624
Skipped 0
Total 321624

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm
Copy link
Member Author

trentm commented Oct 18, 2022

I think that'll possibly fail for a couple of days until the Docker "node:19"-labelled containers are published. That usually lags a bit.

Yup. Test failure in Jenkins:

2022-10-18T20:29:03.472Z] Service 'node_tests' failed to build: manifest for node:19 not found: manifest unknown: manifest unknown

We'll be waiting for nodejs/docker-node#1792 to go through and https://hub.docker.com/_/node to have a "node:19" image.

@trentm
Copy link
Member Author

trentm commented Oct 19, 2022

/test

@trentm trentm marked this pull request as ready for review October 20, 2022 22:13
@trentm trentm requested a review from astorm October 20, 2022 22:13
@trentm trentm merged commit 594c94c into main Oct 27, 2022
@trentm trentm deleted the trentm/node-19 branch October 27, 2022 17:56
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants