Skip to content

Support for Metrics #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
astorm opened this issue Feb 1, 2022 · 3 comments · Fixed by #202
Closed
3 tasks

Support for Metrics #108

astorm opened this issue Feb 1, 2022 · 3 comments · Fixed by #202
Assignees
Labels
aws-λ-extension AWS Lambda Extension enhancement New feature or request
Milestone

Comments

@astorm
Copy link
Contributor

astorm commented Feb 1, 2022

We should decide on a strategy for reporting metrics (such as memory usage, total available memory, billing duration/init duration, etc.). This may mean making the agent's metrics work inside a lambda function, it may mean using the Lambda Logs API to look for and report metrics, it may means leveraging metric beat or function beat, or may mean some other thing.

  • Decide on Metrics Strategy
  • Decide which Metrics to Collect
  • Expose Lambda specific metrics via UI
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Feb 1, 2022
@AlexanderWert
Copy link
Member

AlexanderWert commented Feb 3, 2022

Community & customer feedback:

  • a solution that does not involve interaction with CloudWatch is preferred for costs and rate limiting reasons
  • possibility to write metrics to logstash (instead of directly to the APM server)
  • metrics indicating efficiency would be very valuable (throttles, CPU time/usage, Memory consumption)

Proposal: let's start as simple as collecting the metrics provided by the Lambda platform logs:

  • Duration
  • Billed Duration
  • Memory Size
  • Memory Used
  • Init Duration

@jlvoiseux jlvoiseux self-assigned this Feb 15, 2022
@jlvoiseux jlvoiseux linked a pull request Feb 18, 2022 that will close this issue
6 tasks
@estolfo estolfo changed the title Support for Metrics? Support for Metrics Feb 23, 2022
@estolfo estolfo added this to the 8.3 milestone Mar 29, 2022
@simitt simitt removed this from the 8.3 milestone May 25, 2022
@simitt simitt added this to the 8.4 milestone Jun 3, 2022
@simitt simitt added enhancement New feature or request and removed 8.4-candidate labels Jun 3, 2022
@jlvoiseux
Copy link
Contributor

Was closed by mistake upon merging #202 - We still need to update the APM model to properly include faas information alongside the metrics (ie. replace labels.faas_xxxx by faas.xxxx).

@axw
Copy link
Member

axw commented Jun 20, 2022

With elastic/apm-server#8400 merged, I think we can close this. Server support will be in 8.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-λ-extension AWS Lambda Extension enhancement New feature or request
Projects
None yet
6 participants