Skip to content

Replace metrics labels by dedicated faas fields #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 17, 2022

Conversation

jlvoiseux
Copy link
Contributor

@jlvoiseux jlvoiseux commented Jun 15, 2022

Motivation / Summary

This PR is the finishing touch to the implementation of Lambda platform metrics support. It resolves elastic/apm-server#7714 and #108.

It consists in replacing the following fields:

  • labels.faas_coldstart
  • labels.faas_execution
  • labels.faas_id

by a faas object in the metricset generated by the Lambda extension. The following fields will then be sent to the APM Server:

  • faas.coldstart
  • faas.execution
  • faas.id

Changes

The changes affect extension/process_metrics.go, and consist in creating the aforementioned faas object. The Go Agent APM model is also modified accordingly, as is the APM Server decoder.

How to test

image

Linked Pull Requests

elastic/apm-server#8373
elastic/apm-agent-go#1259

@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jun 15, 2022
@apmmachine
Copy link

apmmachine commented Jun 15, 2022

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-16T06:35:43.344+0000

  • Duration: 63 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 110
Skipped 2
Total 112

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jlvoiseux jlvoiseux marked this pull request as ready for review June 16, 2022 07:00
@jlvoiseux jlvoiseux requested a review from a team June 16, 2022 07:01
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just make sure to remove the "replace" before merging please.

@axw axw merged commit 9367197 into elastic:main Jun 17, 2022
@apmmachine
Copy link

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-17T02:51:25.473+0000

  • Duration: 64 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 110
Skipped 2
Total 112

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS Lambda metrics
3 participants