-
Notifications
You must be signed in to change notification settings - Fork 31
Replace metrics labels by dedicated faas fields #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-aws-lambda into faas-model-metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just make sure to remove the "replace" before merging please.
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Motivation / Summary
This PR is the finishing touch to the implementation of Lambda platform metrics support. It resolves elastic/apm-server#7714 and #108.
It consists in replacing the following fields:
labels.faas_coldstart
labels.faas_execution
labels.faas_id
by a
faas
object in themetricset
generated by the Lambda extension. The following fields will then be sent to the APM Server:faas.coldstart
faas.execution
faas.id
Changes
The changes affect
extension/process_metrics.go
, and consist in creating the aforementionedfaas
object. The Go Agent APM model is also modified accordingly, as is the APM Server decoder.How to test
custom-apm-server
together with ngrok, onlyELASTIC_APM_LAMBDA_APM_SERVER
to the the address provided by ngrok.Linked Pull Requests
elastic/apm-server#8373
elastic/apm-agent-go#1259