Skip to content

fix: handle main loop errors correctly #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Conversation

kruskall
Copy link
Member

Do not call fatal or panic directly, instead propagate the error
to avoid multiple point of failure.

Do not call fatal or panic directly, instead propagate the error
to avoid multiple point of failure.
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jul 28, 2022
@apmmachine
Copy link

apmmachine commented Jul 28, 2022

❕ Build Aborted

Either there was a build timeout or someone aborted the build.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-29T11:37:33.564+0000

  • Duration: 63 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 98
Skipped 32
Total 130

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kruskall kruskall merged commit 04494ab into elastic:main Jul 29, 2022
@kruskall kruskall deleted the fix/main-loop branch July 29, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants