Skip to content

Remove experimental CLI #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2022
Merged

Remove experimental CLI #301

merged 1 commit into from
Sep 12, 2022

Conversation

axw
Copy link
Member

@axw axw commented Sep 9, 2022

See #293 (comment) and proceeding comments.

Closes #293

@axw axw requested a review from simitt September 9, 2022 03:32
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Sep 9, 2022
@apmmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-09T03:32:44.467+0000

  • Duration: 8 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 160
Skipped 2
Total 162

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

simitt
simitt approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@astorm any concerns from your side when removing the CLI? (see reasoning in #293)

@axw axw merged commit f503f5c into elastic:main Sep 12, 2022
@axw axw deleted the remove-cli branch September 12, 2022 00:48
@astorm
Copy link
Contributor

astorm commented Sep 12, 2022

any concerns from your side when removing the CLI?

Nope, no concerns. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simitt simitt simitt approved these changes

@kruskall kruskall kruskall approved these changes

Assignees
No one assigned
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update cli packages where necssary
5 participants
@axw @apmmachine @astorm @simitt @kruskall