This repository was archived by the owner on Aug 4, 2023. It is now read-only.
fix: abort current request if server responds early #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
watson
force-pushed
the
abort
branch
3 times, most recently
from
021e57b to
5873547
Compare
If the server responds before the client have ended the request, it means something didn't go as planned and the server have given up trying to process the request. It therefore doesn't serve any purpose to continue sending data to the server in that request and we should abort.
Qard
approved these changes
Nov 12, 2018
trentm
added a commit
to trentm/apm-nodejs-http-client
that referenced
this pull request
Mar 11, 2021
- fix 'assert' usage for node 8.6 - always destroy the intakeReq on error, I observed (in node 8.6 at least) a intakeReq "timeout" after both a "close" and "error" event. I guess those don't clear the socket timeout. I'm not sure if this is tied to keep-alive agent. In any case, if there is an error, let's make sure to recycle that socket. - gzipStream.pause() on premature response from APM server just in the rare/unlikely case reading the response body and destroying takes a long while. This is a nod to elastic#32 but I'm not sure it is necessary. Doesn't hurt.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server responds before the client have ended the request, it means something didn't go as planned and the server have given up trying to process the request. It therefore doesn't serve any purpose to continue sending data to the server in that request and we should abort.