Skip to content

Fix to support JPMS #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix to support JPMS #334

wants to merge 3 commits into from

Conversation

OpenHelios
Copy link

@OpenHelios OpenHelios commented Jun 4, 2025

This is a fix for #332.

This change needs to update the dependency of logback-classic from 1.2.13 to 1.3.15, because 1.3.x is the first version, which supports JPMS, i.e. it includes the needed module-info file.

Only in the main project ecs-logging-core and in logback-ecs-encoder the module-info file has been added. Also in jul-ecs-formatter and log4j-* projects a module-info file could be added in a similar way.

@OpenHelios OpenHelios requested a review from a team as a code owner June 4, 2025 20:20
Copy link

cla-checker-service bot commented Jun 4, 2025

💚 CLA has been signed

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage Issues and PRs that need to be triaged labels Jun 4, 2025
@OpenHelios OpenHelios changed the title Fix to suppert JPMS Fix to support JPMS Jun 4, 2025
@OpenHelios
Copy link
Author

The process to sign the contributor agreement does not work for me https://www.elastic.co/contributor-agreement Only the progress bar runs to end, but nothing more happens.

@SylvainJuge
Copy link
Member

The process to sign the contributor agreement does not work for me https://www.elastic.co/contributor-agreement Only the progress bar runs to end, but nothing more happens.

The commits are using [email protected] as email adress, I am not 100% sure but this might be the issue here, could you try to use your non-anonymous email address here ?

This is needed to support JPMS, because 1.3.x is
the first release including the module-info file.
@OpenHelios
Copy link
Author

OpenHelios commented Jun 12, 2025

I gave the signing process an other try by pushing the commits with my real email address. With Chromium and not with Firefox I was able to start the signing process, but at the end after clicking "Finish" I get the error message "apps.docusign.com hat die Verbindung abgelehnt.", which means translated to English, that the connection was rejected. What am i missing?
Now signing was successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community triage Issues and PRs that need to be triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants