Skip to content

Possibility to specify an id and a title (label) for series separately #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks
sulemanof opened this issue Apr 1, 2019 · 1 comment · Fixed by #142
Closed
3 tasks

Possibility to specify an id and a title (label) for series separately #136

sulemanof opened this issue Apr 1, 2019 · 1 comment · Fixed by #142
Assignees
@markov00
Labels
enhancement New feature or request released Issue released publicly

Comments

@sulemanof
Copy link

Is your feature request related to a problem? Please describe.
Currently a series title is calculated from the series id prop. But it is not really useful, because series could have same labels in different series. In such case I currently can't create different series with same labels.

Describe the solution you'd like
It would be better to support to separate prop for a title (or label ):
<Series id={getSpecId(series.id + series.label)} title={series.label} />

or <Series id={getSpecId(series.id + series.label)} label={series.label} />

Additional context
Add any other context or screenshots about the feature request here.

Kibana Cross Issues
Add any Kibana related issues/feature requests here.

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@sulemanof sulemanof added the enhancement New feature or request label Apr 1, 2019
@markov00 markov00 mentioned this issue Apr 1, 2019
Closed
93 tasks
@markov00 markov00 added this to the 7.1 milestone Apr 1, 2019
markov00 added a commit to markov00/elastic-charts that referenced this issue Apr 1, 2019
@markov00
feat(specs): add name to series specs
0cf8835 
A `name` prop is now available for each series. This name will be used, if available, on every
legend or tooltip instead of the specId (used as fallback).

fix elastic#136
@markov00 markov00 mentioned this issue Apr 1, 2019
Merged
4 tasks
@markov00 markov00 self-assigned this Apr 1, 2019
markov00 added a commit that referenced this issue Apr 1, 2019
@markov00
feat(specs): add name to series specs (#142)
a6e6f49 
A `name` prop is now available for each series. This name will be used, if available, on every
legend or tooltip instead of the specId (used as fallback).

fix #136
markov00 pushed a commit that referenced this issue Apr 1, 2019
@semantic-release-bot
chore(release): 3.5.0 [skip ci]
a548484 
# [3.5.0](v3.4.5...v3.5.0) (2019-04-01)

### Bug Fixes

* **areachart:** fix misaligned rendering props  ([#141](#141)) ([9694b5b](9694b5b)), closes [#140](#140)

### Features

* **specs:** add name to series specs ([#142](#142)) ([a6e6f49](a6e6f49)), closes [#136](#136)
@markov00
Copy link
Member

markov00 commented Apr 1, 2019

🎉 This issue has been resolved in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Apr 1, 2019
@markov00 markov00 mentioned this issue Apr 4, 2019
Closed
19 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 3.5.0 [skip ci]
f802240 
# [3.5.0](elastic/elastic-charts@v3.4.5...v3.5.0) (2019-04-01)

### Bug Fixes

* **areachart:** fix misaligned rendering props  ([opensearch-project#141](elastic/elastic-charts#141)) ([d627f4d](elastic/elastic-charts@d627f4d)), closes [opensearch-project#140](elastic/elastic-charts#140)

### Features

* **specs:** add name to series specs ([opensearch-project#142](elastic/elastic-charts#142)) ([c045eee](elastic/elastic-charts@c045eee)), closes [opensearch-project#136](elastic/elastic-charts#136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
enhancement New feature or request released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(specs): add name to series specs markov00/elastic-charts
2 participants
@markov00 @sulemanof