Switch to pytest-asyncio's strict mode for async tests

[miguelgrinberg]

The trick is to using the following for async tests:

@pytest.mark.asyncio

which is convert to the following for the unasynced tests:

@pytest.mark.sync

This eliminates issues with unused imports, which would need to be taken care of in some, but not all files. WDYT?

[pquentin]

Thanks!

I think syncio is just too close to asyncio (to the point where my phone autocorrects it back to asyncio). I would be OK with sync or any other word with a Levenshtein distance >= 2 from asyncio.

(I would also be OK with a sed solution until unasync learns to deal with multi-token deletion rules.)

[miguelgrinberg]

A sed solution for this is tricky. Some of the test files do import pytest only to use @pytest.mark.asyncio, while others use it for other things, so it gets difficult to know when the import needs to be removed and when it has to be left alone.

Good point on the name, I'll change it.

[pquentin]

Thanks! LGTM.

[pquentin]

Why is this needed now? Also, I think @pytest_asyncio.fixture and @pytest.fixture are probably clearer than @fixture, but that can be addressed further down the road.

[miguelgrinberg]

This is because pytest-asyncio's auto mode also takes care of reconfiguring any async fixtures declared with @pytest.fixture appropriately. In strict mode you have to use @pytest_asyncio.fixture instead.

I agree that @pytest.fixture is better than @fixture here, I'll change it.

[github-actions]

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-1782-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 81181ca8859f6ef8683ee1b323288bb52605f25a
# Push it to GitHub
git push --set-upstream origin backport-1782-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-1782-to-8.x.