Skip to content

Replace confusing ToggleSort(bool) with Order(SortOrder) on sort descrip... #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2014
Merged

Replace confusing ToggleSort(bool) with Order(SortOrder) on sort descrip... #764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/Nest/DSL/Search/SortFieldDescriptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,12 @@ public virtual SortFieldDescriptor<T> Descending()
return this;
}

public virtual SortFieldDescriptor<T> Order(SortOrder order)
{
Self.Order = order;
return this;
}

public virtual SortFieldDescriptor<T> NestedMin()
{
Self.Mode = ScoreMode.Min;
Expand Down Expand Up @@ -169,14 +175,5 @@ public SortFieldDescriptor<T> NestedPath(Expression<Func<T, object>> objectPath)
Self.NestedPath = objectPath;
return this;
}

/// <summary>
/// Pass true to sort ascending false to sort descending
/// </summary>
public virtual SortFieldDescriptor<T> ToggleSort(bool ascending)
{
Self.Order = ascending ? SortOrder.Descending : SortOrder.Ascending;
return this;
}
}
}
8 changes: 3 additions & 5 deletions src/Nest/DSL/Search/SortGeoDistanceDescriptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,10 @@ public SortGeoDistanceDescriptor<T> Descending()
Self.Order = SortOrder.Descending;
return this;
}
/// <summary>
/// Pass true to sort ascending false to sort descending
/// </summary>
public SortGeoDistanceDescriptor<T> ToggleSort(bool ascending)

public SortGeoDistanceDescriptor<T> Order(SortOrder order)
{
Self.Order = ascending ? SortOrder.Ascending : SortOrder.Descending;
Self.Order = order;
return this;
}

Expand Down
7 changes: 2 additions & 5 deletions src/Nest/DSL/Search/SortScriptDescriptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,9 @@ public virtual SortScriptDescriptor<T> Descending()
return this;
}

/// <summary>
/// Pass true to sort ascending false to sort descending
/// </summary>
public SortScriptDescriptor<T> ToggleSort(bool ascending)
public SortScriptDescriptor<T> Order(SortOrder order)
{
Self.Order = ascending ? SortOrder.Ascending : SortOrder.Descending;
Self.Order = order;
return this;
}
}
Expand Down