-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Handle RecursionError exception in perform_request (issue 1602) #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
Gotcha, so the problem really is that we're swallowing the Also you'll need to sign the CLA for me to merge. |
Yes that's the case :) . Does accepting CLA take some time to propagate or as I have signed it? |
@hmilkovi Did you sign the CLA with the same email address as the one used in your Git commits? |
CLA check (read up in docs that I need to comment again) |
I have changed email on my last commit. Do I need to change it on all or is it easier to make this changes on new branch and new PR? Sorry for bothering you with that. |
Yeah creating a new PR is probably best |
Closing this one for #1609 . |
Propagate RecursionError if it happends on lower levels so when used like:
doesn't crash python interpreter with core dump.
Personal opinion is that this is really needed when we you web servers like uwsgi, gunicorn as
then the whole web server dies and doesn't return http 500 status code.
Related issue: #1602