Skip to content

Deprecate 'doc_type' for query parameters #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Conversation

sethmlarson
Copy link
Contributor

Having doc_type be anywhere except preceding <index> in an API path was basically a mistake that got missed during API generation. We had a universal rule that converted type -> doc_type. This isn't necessary as type isn't a reserved keyword so in 8.x we'd like to start using type.

We can keep all the occurrences of doc_type where it's being used properly as those usages are already deprecated server-side by Elasticsearch. They'll all be removed in 8.x automatically so we'll just let them be. However the usages that were introduced by accident won't go away magically on their own so this PR adds those deprecations.

@sethmlarson sethmlarson merged commit ade0b13 into 7.x Sep 8, 2021
@sethmlarson sethmlarson deleted the deprecate-doc-type branch September 8, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant