Deprecate 'doc_type' for query parameters #1713
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
doc_type
be anywhere except preceding<index>
in an API path was basically a mistake that got missed during API generation. We had a universal rule that convertedtype
->doc_type
. This isn't necessary astype
isn't a reserved keyword so in 8.x we'd like to start usingtype
.We can keep all the occurrences of
doc_type
where it's being used properly as those usages are already deprecated server-side by Elasticsearch. They'll all be removed in 8.x automatically so we'll just let them be. However the usages that were introduced by accident won't go away magically on their own so this PR adds those deprecations.