-
Notifications
You must be signed in to change notification settings - Fork 1.2k
VectorStore for GenAI integrations #2528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 28 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
f30f1ad
ElasticsearchStore
maxjakob e03a17f
Update elasticsearch/store/_utilities.py
maxjakob 8ff1c7c
rename; depend on client; async only
maxjakob 9be44fd
generate _sync files
maxjakob 7ee3846
add cleanup step for _sync generation
maxjakob 2fd89bd
fix formatting
maxjakob 9387b74
more linting fixes
maxjakob b18d63d
batch embedding call; infer num_dimensions
maxjakob 9f83408
revert accidental changes
maxjakob 9803414
keep field names only in store; apply metadata mappings in store
maxjakob 7647961
fix typos in file names
maxjakob d397982
use `elasticsearch_url` fixture; create conftest.py
maxjakob 2f1fcb0
export relevant classes
maxjakob b19de27
remove Semantic strategy
maxjakob 274911a
es_query is sync
maxjakob 8cec9cc
async strategies
maxjakob bbf2be9
cleanup old file
maxjakob 299cd94
add docker-compose service with model deployment
maxjakob 5f0d98d
optional dependencies for MMR
maxjakob 58c8b7d
only test sync parts
maxjakob 994b412
cleanup unasync script
maxjakob 5073af1
nox: install optional deps
maxjakob 9c50c6d
fix tests with requests remembering Transport
maxjakob a99a4f4
fix numpy typing
maxjakob d3c2e62
add user agent default argument
maxjakob 11c8825
move to `elasticsearch.helpers.vectorstore`
maxjakob 0d94881
use Protocol over ABC
maxjakob 6aa6d73
revert Protocol change because Python 3.7
maxjakob 71ca330
address PR feedback:
maxjakob a5dea84
improve docstring
maxjakob 6f81af9
fix metadata mappings issue
maxjakob 881d56c
address PR feedback
maxjakob f32ceb2
add error tests for strategies
maxjakob 9b1778e
canonical names, keyword args only
maxjakob a8d80f2
fix sparse vector strategy bug (duplicate `size`)
maxjakob d27f9f8
all wildcard deletes in compose ES
maxjakob File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
# Licensed to Elasticsearch B.V. under one or more contributor | ||
# license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright | ||
# ownership. Elasticsearch B.V. licenses this file to you under | ||
# the Apache License, Version 2.0 (the "License"); you may | ||
# not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
from elasticsearch.helpers.vectorstore._async.embedding_service import ( | ||
AsyncElasticsearchEmbeddings, | ||
AsyncEmbeddingService, | ||
) | ||
from elasticsearch.helpers.vectorstore._async.strategies import ( | ||
AsyncBM25, | ||
AsyncDenseVector, | ||
AsyncDenseVectorScriptScore, | ||
AsyncRetrievalStrategy, | ||
AsyncSparseVector, | ||
) | ||
from elasticsearch.helpers.vectorstore._async.vectorstore import AsyncVectorStore | ||
from elasticsearch.helpers.vectorstore._sync.embedding_service import ( | ||
ElasticsearchEmbeddings, | ||
EmbeddingService, | ||
) | ||
from elasticsearch.helpers.vectorstore._sync.strategies import ( | ||
BM25, | ||
DenseVector, | ||
DenseVectorScriptScore, | ||
RetrievalStrategy, | ||
SparseVector, | ||
) | ||
from elasticsearch.helpers.vectorstore._sync.vectorstore import VectorStore | ||
from elasticsearch.helpers.vectorstore._utils import DistanceMetric | ||
|
||
__all__ = [ | ||
"BM25", | ||
"DenseVector", | ||
"DenseVectorScriptScore", | ||
"ElasticsearchEmbeddings", | ||
"EmbeddingService", | ||
"RetrievalStrategy", | ||
"SparseVector", | ||
"VectorStore", | ||
"AsyncBM25", | ||
"AsyncDenseVector", | ||
"AsyncDenseVectorScriptScore", | ||
"AsyncElasticsearchEmbeddings", | ||
"AsyncEmbeddingService", | ||
"AsyncRetrievalStrategy", | ||
"AsyncSparseVector", | ||
"AsyncVectorStore", | ||
"DistanceMetric", | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Licensed to Elasticsearch B.V. under one or more contributor | ||
# license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright | ||
# ownership. Elasticsearch B.V. licenses this file to you under | ||
# the Apache License, Version 2.0 (the "License"); you may | ||
# not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# Licensed to Elasticsearch B.V. under one or more contributor | ||
# license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright | ||
# ownership. Elasticsearch B.V. licenses this file to you under | ||
# the Apache License, Version 2.0 (the "License"); you may | ||
# not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
from elasticsearch import ( | ||
AsyncElasticsearch, | ||
BadRequestError, | ||
ConflictError, | ||
NotFoundError, | ||
) | ||
|
||
|
||
async def model_must_be_deployed(client: AsyncElasticsearch, model_id: str) -> None: | ||
try: | ||
dummy = {"x": "y"} | ||
await client.ml.infer_trained_model(model_id=model_id, docs=[dummy]) | ||
except NotFoundError as err: | ||
raise err | ||
except ConflictError as err: | ||
raise NotFoundError( | ||
maxjakob marked this conversation as resolved.
Show resolved
Hide resolved
|
||
f"model '{model_id}' not found, please deploy it first", | ||
meta=err.meta, | ||
body=err.body, | ||
) from err | ||
except BadRequestError: | ||
# This error is expected because we do not know the expected document | ||
# shape and just use a dummy doc above. | ||
pass | ||
|
||
return None | ||
|
||
|
||
async def model_is_deployed(es_client: AsyncElasticsearch, model_id: str) -> bool: | ||
try: | ||
await model_must_be_deployed(es_client, model_id) | ||
return True | ||
except NotFoundError: | ||
return False |
97 changes: 97 additions & 0 deletions
97
elasticsearch/helpers/vectorstore/_async/embedding_service.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
# Licensed to Elasticsearch B.V. under one or more contributor | ||
# license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright | ||
# ownership. Elasticsearch B.V. licenses this file to you under | ||
# the Apache License, Version 2.0 (the "License"); you may | ||
# not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
from abc import ABC, abstractmethod | ||
from typing import List, Optional | ||
|
||
from elasticsearch import AsyncElasticsearch | ||
|
||
|
||
class AsyncEmbeddingService(ABC): | ||
@abstractmethod | ||
async def embed_documents(self, texts: List[str]) -> List[List[float]]: | ||
"""Generate embeddings for a list of documents. | ||
|
||
Args: | ||
maxjakob marked this conversation as resolved.
Show resolved
Hide resolved
|
||
texts: A list of document strings to generate embeddings for. | ||
|
||
Returns: | ||
A list of embeddings, one for each document in the input. | ||
""" | ||
|
||
@abstractmethod | ||
async def embed_query(self, query: str) -> List[float]: | ||
"""Generate an embedding for a single query text. | ||
|
||
Args: | ||
text: The query text to generate an embedding for. | ||
|
||
Returns: | ||
The embedding for the input query text. | ||
""" | ||
|
||
|
||
class AsyncElasticsearchEmbeddings(AsyncEmbeddingService): | ||
"""Elasticsearch as a service for embedding model inference. | ||
|
||
You need to have an embedding model downloaded and deployed in Elasticsearch: | ||
- https://www.elastic.co/guide/en/elasticsearch/reference/current/infer-trained-model.html | ||
- https://www.elastic.co/guide/en/machine-learning/current/ml-nlp-deploy-models.html | ||
""" # noqa: E501 | ||
|
||
def __init__( | ||
self, | ||
es_client: AsyncElasticsearch, | ||
user_agent: str, | ||
model_id: str, | ||
input_field: str = "text_field", | ||
num_dimensions: Optional[int] = None, | ||
maxjakob marked this conversation as resolved.
Show resolved
Hide resolved
|
||
): | ||
""" | ||
Args: | ||
agent_header: user agent header specific to the 3rd party integration. | ||
Used for usage tracking in Elastic Cloud. | ||
model_id: The model_id of the model deployed in the Elasticsearch cluster. | ||
input_field: The name of the key for the input text field in the | ||
document. Defaults to 'text_field'. | ||
num_dimensions: The number of embedding dimensions. If None, then dimensions | ||
will be infer from an example inference call. | ||
maxjakob marked this conversation as resolved.
Show resolved
Hide resolved
|
||
es_client: Elasticsearch client connection. Alternatively specify the | ||
Elasticsearch connection with the other es_* parameters. | ||
""" | ||
# Add integration-specific usage header for tracking usage in Elastic Cloud. | ||
# client.options preserces existing (non-user-agent) headers. | ||
es_client = es_client.options(headers={"User-Agent": user_agent}) | ||
|
||
self.client = es_client.ml | ||
self.model_id = model_id | ||
self.input_field = input_field | ||
self._num_dimensions = num_dimensions | ||
|
||
async def embed_documents(self, texts: List[str]) -> List[List[float]]: | ||
result = await self._embedding_func(texts) | ||
return result | ||
|
||
async def embed_query(self, text: str) -> List[float]: | ||
result = await self._embedding_func([text]) | ||
return result[0] | ||
|
||
async def _embedding_func(self, texts: List[str]) -> List[List[float]]: | ||
response = await self.client.infer_trained_model( | ||
model_id=self.model_id, docs=[{self.input_field: text} for text in texts] | ||
) | ||
return [doc["predicted_value"] for doc in response["inference_results"]] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.