Request parsing of terms query not working as expected

[reijnden]

In our project we try to parse a search request with the typedAPI as follows

request, err := search.NewRequest().FromJSON(jsonstr) if err != nil { log.Errorf("failed to create request 1: " + err.Error()) return nil, err }
When we send a bool query with filter on terms, the terms part is being ignored. For example this query

{ "query": { "bool": { "filter": [ { "terms": { "Fields.lcf": [ "bifd", "xxx" ] } } ], "must": { "multi_match": { "query": "possibility", "fields": [ "Text", "Title^3" ] } } } } }

The resulting request does not hold the full terms section. It will be
terms: {}

Now if I change the input query as below it works, but this is obviously not a valid query to send to Elastic

{ "query": { "bool": { "filter": [ { "terms": { "TermsQuery": { "Fields.lcf": [ "bifd", "xxx" ] } } } ], "must": { "multi_match": { "query": "possibility", "fields": [ "Text", "Title^3" ] } } } } }

Am i missing something or is the API buggy here?

Thanks

[reijnden]

I am attaching a small program that illustrates the issue:
test.tgz

[Anaethelion]

Thank you for reporting this!

This is indeed a bug in the deserialization logic where AdditionalProperty should be handled like AdditionalProperties and seems not to be.

I've got a fix in the works, I'll update this issue once I've tested this further.

[reijnden]

Sure, you're welcome. Anything I can do let me know.