Skip to content
This repository was archived by the owner on Jan 31, 2024. It is now read-only.

[elastic] Don't send the error messages to the client. #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

movie-travel-code
Copy link

Add wrapper NoDiagnosticsReply to jsonrpc2.Request.Reply. Just call
NoDiagnosticsReply for the handlers we used

Add wrapper `NoDiagnosticsReply` to `jsonrpc2.Request.Reply`.  Just call
`NoDiagnosticsReply` for the handlers we used
@AppVeyorBot
Copy link

Copy link

@zfy0701 zfy0701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is not sending errors back to the client, the cost is low

it's more of a problem disabling diagnostic computation in the begining, if it is hard to do we could take time to analyze them later

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants