Skip to content
This repository was archived by the owner on Jan 31, 2024. It is now read-only.

[elastic] Try invoke 'go list ...' again if we get nothing from… #85

Merged

Conversation

movie-travel-code
Copy link

@movie-travel-code movie-travel-code commented Sep 3, 2019

… the previous 'go list ...' invoke

The original 'go list ...' invoke has strict limitations about the load
mode, once 'go list ...' failed, we will get nothing about the packages.

For this case, try to invoke 'go list ...' with weaker limitations, like
without any dependency related information query. Although the
information we get is limited to the current file, it is better than
nothing.

@AppVeyorBot
Copy link

@movie-travel-code
Copy link
Author

movie-travel-code commented Sep 3, 2019

The tests.

Kubernetes Symbol Count Index time
#79 (comment) 116707 1005.466s
#84 (comment) 116707 1037.315s
Current PR 118100 1123s
tidb Symbol Count Index time
#79 (comment) 18728 58.333s
#84 (comment) 18728 53.96s
Current PR 19358 87.725s
etcd Symbol Count Index time
#79 (comment) 15075 84.813s
#84 (comment) 15075 69.373s
Current PR 15075 72.84s

…revious 'go list ...' invoke

The original 'go list ...' invoke has strict limitations about the load
mode, once 'go list ...' failed, we will get nothing about the packages.

For this case, try to invoke 'go list ...' with weaker limitations, like
without any dependency related information query. Although the
information we get is limited to the current file, it is better than
nothing.
@AppVeyorBot
Copy link

@movie-travel-code movie-travel-code changed the title [elastic] [WIP] Try invoke 'go list ...' again if we get nothing from… [elastic] Try invoke 'go list ...' again if we get nothing from… Sep 3, 2019
@movie-travel-code movie-travel-code merged commit 7b98147 into elastic:master Sep 4, 2019
@movie-travel-code movie-travel-code deleted the try_go_list_again branch September 4, 2019 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants