Send map filters through $newFilters so they get picked up by both kuery and lucene #13251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bargs
added
:Discovery
Feature:Visualizations
thomasneirynck
approved these changes
Aug 1, 2017
|
Thanks for the quick review guys 🎉 |
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 1, 2017
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 1, 2017
This was referenced Aug 1, 2017
Merged
Bargs
added a commit
that referenced
this pull request
Aug 1, 2017
Bargs
added a commit
that referenced
this pull request
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should never push new filters from visualizations directly into the
filtersapp state. The new Kuery language doesn't look at the filters variable. There are watchers for both lucene and kuery that handle filters added to$newFilters, so we should always go through$newFiltersuntil we build a better API.Fixes #13227