fix: ensure description field for elasticstack_kibana_security_role behaves as optional #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idation errors The description field was being set unconditionally in resourceRoleRead, which caused Terraform to reject the plan when the description was empty because it was trying to set a non-computed attribute to an empty string. This fix ensures that the description field is only set when it contains actual content, preventing the 'Provider produced invalid plan' error for elasticstack_kibana_security_role resources without descriptions. Fixes: elastic#1186
snobear
changed the title
|
cc @tobio |
tobio
reviewed
Aug 14, 2025
There was a problem hiding this comment.
Thanks for getting involved @snobear.
Two things:
- The current acceptance tests are passing, but don't set the description attribute. It seems like the actual bug here is slightly more subtle (or maybe specific to some Terraform version). It would be great to understand what that is though. Are you able to add an acceptance test which fails without this change, but is fixed by this PR?
- Are you able to add an entry to
CHANGELOG.mdfor this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description field added in #1186 was intended to be optional, but I found that when it is not set it causes:
It was being set unconditionally in
resourceRoleRead, which caused Terraform to reject the plan when the description was empty because it was trying to set a non-computed attribute to an empty string. This ensures that the description field is only set when it contains actual content, so it can be optional.