-
Notifications
You must be signed in to change notification settings - Fork 117
fix: make synthetics
fleet namespace aware
#1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This duplicates #1208 |
@tobio , sorry, I missed the original PR. Feel free to close this if it doesn't help. Most important to have functionality work. |
Optional: true, | ||
PlanModifiers: []planmodifier.String{ | ||
stringplanmodifier.UseStateForUnknown(), | ||
stringplanmodifier.RequiresReplace(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@biscout42 TODO: not the case, we could update namespace w/o changing a monitor. The monitor will write data for new test in new datastream in the case of a change.
This PR fixes
namespace
usage in synthetic monitors. It separates Kibanaspace_id
the monitor is saved in from thenamespace
, the data stream namespace for Fleet.In addition:
9.x
, related to Remove Dashboard Import/Export API kibana#414399.1
has fleet policy namespace aware.