Fix room.leave event on MatrixClient emitter to emit when the bot is banned.
#52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure wtf was going on with that if but i think it always returned early no matter what, so i have changed it to do what i think it is trying to do. Ban events used to be ignored for sure.
If the client isn't alerted to leaving a room this can be pretty serious and represents a flaw in the SDK.
Gnuxie
force-pushed
the
gnuxie/room-ban
branch
from
689e2c4 to
7eb5d21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Signed-off-by: Gnuxie [email protected]