Skip to content

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Aug 20, 2025

Spawning from #18804 (comment) as mentioned by @richvdh,

[...] the goal is just to use async/await all the way up the chain so the trace_servlet doesn't close until we're finished and LoggingContext.scope sticks around until the end as expected.

But we're no longer using LoggingContext.scope since moving to OpenTracing's ContextVarsScopeManager in #18849

The benefit now is TODO


In terms of tracing, TODO

Before After
2025-08-20_15-50 .

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@@ -882,6 +880,8 @@ async def _async_write_json_to_request_in_thread(
Note: We don't use JsonEncoder.iterencode here as that falls back to the
Python implementation (rather than the C backend), which is *much* more
expensive.

The actual writing of bytes is not finished when this returns.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel like we might want to copy this comment up the chain to respond_with_json and _send_response/_send_error_response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant