Skip to content

Conversation

mdionisio
Copy link

it can be that node.left.name or node.right.name not exist

Traceback (most recent call last):
File "/home/dionisio/.local/bin/autopxd", line 8, in
sys.exit(cli())
^^^^^
File "/usr/lib/python3/dist-packages/click/core.py", line 1157, in call
return self.main(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/init.py", line 286, in cli
outfile.write(translate(infile.read(), infile.name, extra_cpp_args, debug=debug, regex=regex))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/init.py", line 207, in translate
p.visit(
File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 93, in visit
rv = super().visit(node)
^^^^^^^^^^^^^^^^^^^
File "/home/dionisio/.local/lib/python3.12/site-packages/pycparser/c_ast.py", line 158, in visit
return visitor(node)
^^^^^^^^^^^^^
File "/home/dionisio/.local/lib/python3.12/site-packages/pycparser/c_ast.py", line 165, in generic_visit
self.visit(c)
File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 93, in visit
rv = super().visit(node)
^^^^^^^^^^^^^^^^^^^
File "/home/dionisio/.local/lib/python3.12/site-packages/pycparser/c_ast.py", line 158, in visit
return visitor(node)
^^^^^^^^^^^^^
File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 266, in visit_Typedef
decls = self.collect(node)
^^^^^^^^^^^^^^^^^^
File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 284, in collect
self.generic_visit(node)
File "/home/dionisio/.local/lib/python3.12/site-packages/pycparser/c_ast.py", line 165, in generic_visit
self.visit(c)
File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 93, in visit
rv = super().visit(node)
^^^^^^^^^^^^^^^^^^^
File "/home/dionisio/.local/lib/python3.12/site-packages/pycparser/c_ast.py", line 158, in visit
return visitor(node)
^^^^^^^^^^^^^
File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 200, in visit_TypeDecl
decls = self.collect(node)
^^^^^^^^^^^^^^^^^^
File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 284, in collect
self.generic_visit(node)
File "/home/dionisio/.local/lib/python3.12/site-packages/pycparser/c_ast.py", line 165, in generic_visit
self.visit(c)
File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 93, in visit
rv = super().visit(node)
^^^^^^^^^^^^^^^^^^^
File "/home/dionisio/.local/lib/python3.12/site-packages/pycparser/c_ast.py", line 158, in visit
return visitor(node)
^^^^^^^^^^^^^
File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 158, in visit_Enum
value_as_str, maybe_value_as_int = parse_enum_value(item.value)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 73, in parse_enum_value
value_as_str = f"{node.left.name} {node.op} {node.right.name}"
^^^^^^^^^^^^^^
AttributeError: 'Constant' object has no attribute 'name'

@mdionisio
Copy link
Author

I think that this pull request solve #50

@elijahr
Copy link
Owner

elijahr commented Nov 15, 2024

Thank you for the contribution! Can you add a test illustrating the issue, or at least provide some sample code to reproduce it?

it can be that node.left.name or node.right.name not exist

Traceback (most recent call last):
  File "/home/dionisio/.local/bin/autopxd", line 8, in <module>
    sys.exit(cli())
             ^^^^^
  File "/usr/lib/python3/dist-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/__init__.py", line 286, in cli
    outfile.write(translate(infile.read(), infile.name, extra_cpp_args, debug=debug, regex=regex))
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/__init__.py", line 207, in translate
    p.visit(
  File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 93, in visit
    rv = super().visit(node)
         ^^^^^^^^^^^^^^^^^^^
  File "/home/dionisio/.local/lib/python3.12/site-packages/pycparser/c_ast.py", line 158, in visit
    return visitor(node)
           ^^^^^^^^^^^^^
  File "/home/dionisio/.local/lib/python3.12/site-packages/pycparser/c_ast.py", line 165, in generic_visit
    self.visit(c)
  File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 93, in visit
    rv = super().visit(node)
         ^^^^^^^^^^^^^^^^^^^
  File "/home/dionisio/.local/lib/python3.12/site-packages/pycparser/c_ast.py", line 158, in visit
    return visitor(node)
           ^^^^^^^^^^^^^
  File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 266, in visit_Typedef
    decls = self.collect(node)
            ^^^^^^^^^^^^^^^^^^
  File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 284, in collect
    self.generic_visit(node)
  File "/home/dionisio/.local/lib/python3.12/site-packages/pycparser/c_ast.py", line 165, in generic_visit
    self.visit(c)
  File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 93, in visit
    rv = super().visit(node)
         ^^^^^^^^^^^^^^^^^^^
  File "/home/dionisio/.local/lib/python3.12/site-packages/pycparser/c_ast.py", line 158, in visit
    return visitor(node)
           ^^^^^^^^^^^^^
  File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 200, in visit_TypeDecl
    decls = self.collect(node)
            ^^^^^^^^^^^^^^^^^^
  File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 284, in collect
    self.generic_visit(node)
  File "/home/dionisio/.local/lib/python3.12/site-packages/pycparser/c_ast.py", line 165, in generic_visit
    self.visit(c)
  File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 93, in visit
    rv = super().visit(node)
         ^^^^^^^^^^^^^^^^^^^
  File "/home/dionisio/.local/lib/python3.12/site-packages/pycparser/c_ast.py", line 158, in visit
    return visitor(node)
           ^^^^^^^^^^^^^
  File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 158, in visit_Enum
    value_as_str, maybe_value_as_int = parse_enum_value(item.value)
                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dionisio/.local/lib/python3.12/site-packages/autopxd/writer.py", line 73, in parse_enum_value
    value_as_str = f"{node.left.name} {node.op} {node.right.name}"
                      ^^^^^^^^^^^^^^
AttributeError: 'Constant' object has no attribute 'name'
@mdionisio
Copy link
Author

I update the test and also fix my patch.

@elijahr elijahr merged commit 7e9c4f8 into elijahr:master Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants