Make --min-cycle-size in mix xref graph inclusive
#14475
Merged
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates cycle filtering logic to include cycles matching the minimum size. Improves test cases to ensure accurate handling of `min_cycle_size` scenarios.
jechol
changed the title
--min-cycle-size in mix xref graph inclusive (fixes #14474)--min-cycle-size in mix xref graph inclusive
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the behavior of the
--min-cycle-sizeoption inmix xref graph --format cycles.Previously, cycles with a size equal to the specified minimum were excluded.
For example, running
mix xref graph --format cycles --min-cycle-size 2would only include cycles of size >= 3, which is unintuitive and inconsistent with the option name.This change updates the behavior to be inclusive, so that
--min-cycle-size 2includes all cycles of size >= 2, as expected.Fixes: #14474