Skip to content

Handle empty lists in merge_ranges_lists #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/language_server/lib/language_server/range_utils.ex
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,16 @@ defmodule ElixirLS.LanguageServer.RangeUtils do
result
end

def merge_ranges_lists([], []), do: []

def merge_ranges_lists([], _ranges_2) do
raise ArgumentError, message: "ranges_1 is empty"
end

def merge_ranges_lists(_ranges_1, []) do
raise ArgumentError, message: "ranges_2 is empty"
end

def merge_ranges_lists(ranges_1, ranges_2) do
if hd(ranges_1) != hd(ranges_2) do
raise ArgumentError, message: "range list do not start with the same range"
Expand Down
20 changes: 20 additions & 0 deletions apps/language_server/test/range_utils_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,26 @@ defmodule ElixirLS.LanguageServer.RangeUtilsTest do

assert merge_ranges_lists(range_1, range_2) == expected
end

test "handles empty lists" do
assert merge_ranges_lists([], []) == []
end

test "raises if ranges_1 is empty" do
range_2 = [range(1, 1, 5, 5)]

assert_raise ArgumentError, "ranges_1 is empty", fn ->
merge_ranges_lists([], range_2)
end
end

test "raises if ranges_2 is empty" do
range_1 = [range(1, 1, 5, 5)]

assert_raise ArgumentError, "ranges_2 is empty", fn ->
merge_ranges_lists(range_1, [])
end
end
end

describe "deduplicate/1" do
Expand Down
Loading