fix premature end of JPEG file bug #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, I don't know how I missed the notification on this for so long! Sorry about that and thanks so much for taking the time to submit a PR! Let me play around with this a bit and get it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1
If photo has no barcodes and file don't have EOI 0xFF, 0xD9 - zbar return {:error, "Premature end of JPEG file\n"} and all works correctly.
But If photo has barcode, zbar return {:ok, data: barcode_dada} and {:ok, data: "Premature end of JPEG file\n"}
All we need - add new clause and skip information about broken file - as result - we have barcode on broken file too, and application not raise.