[Discussion] Fix incremental #124
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hooks in place, logging to *Messages*, store the before change value
|
Closes #114 |
We can sometimes get a combined delete and add
|
How would we do a full sync? I don't think we can change the sync method once it has been set during initialization. |
|
When I say full sync I mean this: https://github.com/emacs-lsp/lsp-mode/blob/fix-incremental/lsp-methods.el#L627 Send an incremental change message, but with the entire contents of the buffer. Hopefully this will only be needed rarely, and makes sure the server state matches. |
|
Ah, I forgot that |
|
I have been using it myself, and it seems to work fine. So I am happy to go with it. |
|
Squashed commits and pushed manually, thanks! |
wkirschbaum
pushed a commit
to wkirschbaum/lsp-mode
that referenced
this pull request
Jun 1, 2021
* Update changelog for workspace symbol * Update changelog for 0.3.0 release * Version bump for v0.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
before-changehook to store the original start and end positions, and then takes the end position from that if a delete change must be generated.The emacs documentation warns that the before and after events may not bracket, and may not be the same.
We do a sanity check on them before using, and if there is a mismatch send a full sync instead.