Add the gzipped file to the context's distFiles when keep is true #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By not adding the gzipped files to the distFiles we end up leaving them out of several things e.g. they're never added to the manifest for a build and they're never uploaded with the S3 plugin. In much the same way as the json-config plugin adds the built json file to the context, this PR will mean the gzip plugin now adds all of the gzipped files to the context.
achambers
pushed a commit
that referenced
this pull request
Feb 4, 2016
Add the gzipped file to the context's distFiles when keep is true
|
Champion! Thanks |
|
Good catch! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not adding the gzipped files to the distFiles we end up leaving
them out of several things e.g. they're never added to the manifest
for a build and they're never uploaded with the S3 plugin. In much
the same way as the json-config plugin adds the built json file to
the context, this PR will mean the gzip plugin now adds all of the
gzipped files to the context.
Related to ember-cli-deploy/ember-cli-deploy-s3#46