Add compact to filter autofixer for no-array-prototype-extensions rule
#1611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmish Can you please review? |
bmish
reviewed
Oct 7, 2022
bmish
reviewed
Oct 7, 2022
bmish
added a commit
that referenced
this pull request
Oct 7, 2022
…orn-44.0.0 * master: Add `compact` to `filter` autofixer for `no-array-prototype-extensions` rule (#1611) build(deps-dev): bump release-it from 15.4.2 to 15.5.0 (#1612) build(deps-dev): bump @babel/plugin-proposal-decorators from 7.19.1 to 7.19.3 (#1602) build(deps-dev): bump @typescript-eslint/parser from 5.38.0 to 5.38.1 (#1604) build(deps-dev): bump jsdom from 20.0.0 to 20.0.1 (#1607) build(deps-dev): bump sort-package-json from 1.57.0 to 2.0.0 (#1606) Add `filterBy` to `filter` autofixer for `no-array-prototype-extensions` rule (#1610) Add `any` to `some` autofixer for `no-array-prototype-extensions` rule (#1609)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added auto-fixer for
no-array-prototype-extensionswhich replacescompactwithfilter.Description
Recently, the proposal to deprecate array prototype extensions has been approved and got merged. The plan is to add autoFixers to replace ember array prototype extensions with the native array methods. In this PR, an auto fixer has been added which will replace the ember array method
compactwith the native array methodfilter.Testing
Modified test case to check if the right output is generated after the fix.