tests: use this. in property path in templates
#1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the `id-for-deprecation-test` suite, there are several instances of the [this-property-fallback] deprecation logged to the console. Let's make sure that we always use `this.` in the property path of our inline templates when appropriate. This should help with #1272.
✅ Deploy Preview for ember-deprecations ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ghost
changed the title
this in property path in templatesthis. in property path in templates
ghost
mentioned this pull request
jenweber
approved these changes
Feb 3, 2023
|
Thank you! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the
id-for-deprecation-testsuite, there are several instances of the [this-property-fallback] deprecation logged to the console.Let's make sure that we always use
this.in the property path of our inline templates when appropriate.This should help with #1272.