Skip to content

fix implicit-injections deprecation #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@ import Application from '@ember/application';
import Resolver from 'ember-resolver';
import loadInitializers from 'ember-load-initializers';
import config from 'ember-api-docs/config/environment';
import { importSync, isDevelopingApp, macroCondition } from '@embroider/macros';

import './deprecation-workflow';
if (macroCondition(isDevelopingApp())) {
importSync('./deprecation-workflow');
}

export default class App extends Application {
modulePrefix = config.modulePrefix;
Expand Down
5 changes: 3 additions & 2 deletions app/deprecation-workflow.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import setupDeprecationWorkflow from 'ember-cli-deprecation-workflow';

setupDeprecationWorkflow({
throwOnUnhandled: true,
workflow: [
{ handler: 'silence', matchId: 'ember.component.reopen' },
{ handler: 'silence', matchId: 'implicit-injections' },
{ handler: 'throw', matchId: 'ember.component.reopen' },
{ handler: 'throw', matchId: 'implicit-injections' },
{ handler: 'silence', matchId: 'this-property-fallback' },
{ handler: 'silence', matchId: 'ember-component.is-visible' },
{
Expand Down
2 changes: 2 additions & 0 deletions app/routes/project-version.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ export default class ProjectVersionRoute extends Route {
@service
router;

@service store;

@service('project')
projectService;

Expand Down
2 changes: 2 additions & 0 deletions app/routes/project-version/classes/class.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ export default class ClassRoute extends Route.extend(ScrollTracker) {
@service
metaStore;

@service store;

titleToken(model) {
return model.name;
}
Expand Down
2 changes: 2 additions & 0 deletions app/routes/project-version/functions/function.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ export default class FunctionRoute extends Route {
@service
scrollPositionReset;

@service store;

titleToken(model) {
return model?.fn?.name;
}
Expand Down
3 changes: 3 additions & 0 deletions app/routes/project-version/modules/module.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import ClassRoute from '../classes/class';
import ScrollTracker from 'ember-api-docs/mixins/scroll-tracker';
import getFullVersion from 'ember-api-docs/utils/get-full-version';
import { inject as service } from '@ember/service';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose importing service is not supported on this ember-source version yet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's correct, we're still on 3.28 here 🙈


export default class ModuleRoute extends ClassRoute.extend(ScrollTracker) {
@service store;

async model(params) {
const { project, project_version: compactVersion } =
this.paramsFor('project-version');
Expand Down
3 changes: 3 additions & 0 deletions app/routes/project-version/namespaces/namespace.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import ClassRoute from '../classes/class';
import ScrollTracker from 'ember-api-docs/mixins/scroll-tracker';
import getFullVersion from 'ember-api-docs/utils/get-full-version';
import { inject as service } from '@ember/service';

export default class NamespaceRoute extends ClassRoute.extend(ScrollTracker) {
@service store;

templateName = 'project-version/classes/class';

async model(params) {
Expand Down
2 changes: 2 additions & 0 deletions app/routes/project.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ export default class ProjectRoute extends Route.extend(ScrollTracker) {
@service
router;

@service store;

model({ project: projectName }) {
let projectNameToLookUp = 'ember';

Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"@ember/test-helpers": "^2.6.0",
"@embroider/compat": "^3.4.3",
"@embroider/core": "^3.4.3",
"@embroider/macros": "^1.18.0",
"@embroider/webpack": "^3.2.1",
"@glimmer/component": "^1.1.2",
"@glimmer/tracking": "^1.1.2",
Expand Down
100 changes: 90 additions & 10 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.