Skip to content

[BUGFIX] Restore mixin based EmberArray detection #20219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[BUGFIX] Restore mixin based EmberArray detection #20219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56280bf
Restore mixin based EmberArray detection
jrjohnson Oct 4, 2022
fdbed46
Ask before running Ember.A on something
jrjohnson Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/@ember/array/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1950,12 +1950,21 @@ if (ENV.EXTEND_PROTOTYPES.Array) {
return (arr || []) as NativeArray<T>;
};
} else {
A = function <T>(this: unknown, arr?: Array<T>) {
interface IsEmberAAble {
preventEmberA(): boolean;
}
A = function <T>(this: unknown, arr?: Array<T> | IsEmberAAble) {
assert(
'You cannot create an Ember Array with `new A()`, please update to calling A as a function: `A()`',
!(this instanceof A)
);

if (typeof (arr as IsEmberAAble)?.preventEmberA === 'function') {
if ((arr as IsEmberAAble).preventEmberA()) {
return arr as NativeArray<T>;
}
}

if (isEmberArray(arr)) {
// SAFETY: If it's a true native array and it is also an EmberArray then it should be an Ember NativeArray
return arr as NativeArray<T>;
Expand Down