fix(typescript): Preserve props union type #1252
Conversation
|
Preview Docs Built with commit 238e41e |
eps1lon
changed the title
| @@ -10,6 +10,6 @@ export type PropsOf<C extends React.ComponentType<any>> = C extends React.SFC< | |||
| : never) | |||
| : never | |||
|
|
|||
| export type Omit<T, U> = Pick<T, Exclude<keyof T, U>> | |||
| export type Omit<T, U> = T extends any ? Pick<T, Exclude<keyof T, U>> : never | |||
There was a problem hiding this comment.
I'm not a ts user but in the recommended pattern you linked to, it says T extends unknown rather than T extends any, should it be using unknown or is there a reason for using any?
There was a problem hiding this comment.
As far as I know T extends any would not evaluate to true for every type so unknown is safer. However for objects it should always be true. It is used since unknown was only released in typescript 3.0. If your types don't support 2.x we might as well go full in.
Also
use any instead of unknown for backwards compatibility. If you don't support typescript 2.x we can use unknown
There was a problem hiding this comment.
Oops, didn't see that! I'd rather keep compatibility so I'm good with this.
What:
Omitto be distributive over union typesWhy:
withThemeandstyledloose union type informatonHow:
anyinstead ofunknownfor backwards compatibility. If you don't support typescript 2.x we can useunknownChecklist:
masterstyled-components:[styled-components] Fix union type of props being lost DefinitelyTyped/DefinitelyTyped#33061