Skip to content

Move wasm_simd128.h into upstream LLVM #10714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sunfishcode opened this issue Mar 17, 2020 · 2 comments · Fixed by #10804
Closed

Move wasm_simd128.h into upstream LLVM #10714

sunfishcode opened this issue Mar 17, 2020 · 2 comments · Fixed by #10804
Assignees
@tlively

Comments

@sunfishcode
Copy link
Collaborator

The header wasm_simd128.h would be useful to wasm32-wasi and wasm32-unknown-unknown users, so it would be useful to move to upstream LLVM.

I requested this earlier, and the conclusion was that this makes sense to do, but later. Since then, the SIMD proposal has advanced to Stage 3 and much more of the spec, and this wasm_simd128.h header file, is now stable and tested. And now, we have more users interested in experimenting with SIMD.

@tlively As the primary author of this file, would you be willing to submit a PR to LLVM for this?

Thanks!
@tlively
Copy link
Member

tlively commented Mar 17, 2020

Yes, this sounds fine. I'll make that PR in the next couple days.

@tlively
Copy link
Member

tlively commented Mar 28, 2020

It was a few more than a couple days, but this change is up for review at https://reviews.llvm.org/D76959.

@tlively tlively mentioned this issue Mar 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlively tlively

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove wasm_simd128.h intrinsics header tlively/emscripten
2 participants
@sunfishcode @tlively