Remove wasm_simd128.h intrinsics header #10804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This header has moved to the LLVM project, where it can be more widely used. This PR removes the now-redundant contents of the wasm_simd128.h header in this repository and replaces them with a redirection to the version that now lives in the clang distribution. However, the primary tests for the header are still in this repository. In the process of moving the header to clang, its handling of `-funsigned-char` was corrected, so this PR also adds testing with that flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This header has moved to the LLVM project, where it can be more widely
used. This PR removes the now-redundant contents of the wasm_simd128.h
header in this repository and replaces them with a redirection to the
version that now lives in the clang distribution. However, the primary
tests for the header are still in this repository. In the process of
moving the header to clang, its handling of
-funsigned-charwascorrected, so this PR also adds testing with that flag.
Closes #10714.