You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm re-opening an issue here regarding WebAssembly/binaryen#2180, where the 1.39.4 release does not fix the sample below. How does one validate that Binaryen has been updated since the original issue was fixed? Thanks!
How are you installing emscripten? Are you using the emsdk? You can have binaryen report the version to you by passing --version to any of the tools e.g. wasm-opt --version.
Can you post the output of the command (preferable with EMCC_DEBUG=1).
Is this WebAssembly/binaryen#2622 available with latest emsdk i.e 1.39.6. Because I tried both emsdk install latest and emsdk install tot-upstream, still the issue occurs.
The fix is not in 1.39.6 no. But it should be in tot.
Which version is tot installing for you? You need to run emsdk update-tags before tot gets updated.
You can tell which version of binaryen you have installed by running upstream/bin/wasm-opt --version.
The version should look something like this;
wasm-opt version 90 (version_90-26-g5ca79a71b)
This means binaryen version 90 + 26 additional commits. This fix landed 53 commits after version 90 so if it says less that 53 than you don't have a recent enough version.
We are planning on doing a new emscripten release ASAP that will include this change.
I'm also trying to land a regression test on the emscripten side to prevent this bug from creeping back: #9633
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.
Activity
sbc100 commentedon Dec 3, 2019
This example works fine for me on ToT.
How are you installing emscripten? Are you using the emsdk? You can have binaryen report the version to you by passing
--version
to any of the tools e.g.wasm-opt --version
.Can you post the output of the command (preferable with EMCC_DEBUG=1).
jeromelaban commentedon Dec 3, 2019
I'm installing it this way:
Gives me:
and
The version of wasm-opt does not seem to be aligned, is this expected ?
jeromelaban commentedon Dec 3, 2019
Here is the full log:
sbc100 commentedon Dec 3, 2019
Thanks! I've produced this locally now.
Fix renaming in FixInvokeFunctionNamesWalker
Fix renaming in FixInvokeFunctionNamesWalker
Fix renaming in FixInvokeFunctionNamesWalker
Fix renaming in FixInvokeFunctionNamesWalker
Fix renaming in FixInvokeFunctionNamesWalker
Fix renaming in FixInvokeFunctionNamesWalker (#2513)
rohitsaini1995 commentedon Dec 18, 2019
How can I take this fix into my emsdk llvm backend. As I am not getting the fix in updated emsdk version. Do I need to build binaryen from source.
16 remaining items
sbc100 commentedon Jan 22, 2020
I'm looking at this today. Hopefully we reland the binaryen fix today.
DierkDroth commentedon Jan 23, 2020
@sbc100 that would be much appreciated since @jeromelaban (Platform UNO) is waiting to get that fixed in order to deploy to a new build to us...
Consistent detection of invoke_ functions in PostEmscripten.cpp
Consistent detection of invoke_ functions in PostEmscripten.cpp (#2619)
sbc100 commentedon Jan 24, 2020
Oh the binaryen side of this fix landed again: WebAssembly/binaryen#2622
Hopefully it will stick this time.
rohitsaini1995 commentedon Jan 29, 2020
Is this WebAssembly/binaryen#2622 available with latest emsdk i.e 1.39.6. Because I tried both emsdk install latest and emsdk install tot-upstream, still the issue occurs.
sbc100 commentedon Jan 29, 2020
The fix is not in 1.39.6 no. But it should be in
tot
.Which version is
tot
installing for you? You need to runemsdk update-tags
before tot gets updated.You can tell which version of binaryen you have installed by running
upstream/bin/wasm-opt --version
.The version should look something like this;
This means binaryen version 90 + 26 additional commits. This fix landed 53 commits after version 90 so if it says less that 53 than you don't have a recent enough version.
We are planning on doing a new emscripten release ASAP that will include this change.
I'm also trying to land a regression test on the emscripten side to prevent this bug from creeping back: #9633
Bump mono and emscripten 1.39.7
Bump mono and emscripten 1.39.7
Bump mono and emscripten 1.39.7
stale commentedon Jan 30, 2021
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.