Skip to content

Wasm2js: Allow minification of import/export names #11649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2020
Merged

Wasm2js: Allow minification of import/export names #11649

merged 3 commits into from
Jul 16, 2020

Conversation

kripken
Copy link
Member

@kripken kripken commented Jul 16, 2020

This was disabled due to some bugs with legalization, but those have been
fixed meanwhile (in WebAssembly/binaryen#2926)
so we can do this.

This helps nicely, e.g. 6% shrinking of hello_webgl2_wasm2js in the
minimal runtime size test. cc @juj I think you'll like that 😄

In addition to CI, verified with wasm2js3 locally.

@kripken kripken merged commit f6e623a into master Jul 16, 2020
@kripken kripken deleted the wasm2js branch July 16, 2020 18:57
@juj
Copy link
Collaborator

juj commented Jul 27, 2020

Wow, really nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants