Implement mmap and msync for NODERAWFS #13052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Dec 15, 2020
tests/test_core.py
Outdated
| src = path_from_root('tests', 'fs', 'test_mmap.c') | ||
| out = path_from_root('tests', 'fs', 'test_mmap.out') | ||
| self.emcc_args = orig_compiler_opts + ['-D' + fs] | ||
| if fs == 'NODEFS': | ||
| self.emcc_args += ['-lnodefs.js'] | ||
| if fs == 'NODERAWFS': | ||
| self.emcc_args += ['-sNODERAWFS=1'] |
There was a problem hiding this comment.
Does -lnoderawfs.js work? (like the line two lines above?)
There was a problem hiding this comment.
That works too, but in that case also -lnodefs.js needs to be linked.
(Perhaps we could just synonym -sNODERAWFS=1 with -lnoderawfs.js? See for e.g. kleisauke@b3607b9)
There was a problem hiding this comment.
I included -lnodefs.js and -lnoderawfs.js with commit kleisauke@244e478, but perhaps this (i.e. ['-sNODERAWFS=1'] -> ['-lnodefs.js', '-lnoderawfs.js']) should be done throughout the whole test suite? Let me know if you want a separate PR for this.
sbc100
approved these changes
Dec 16, 2020
+ add a test case that covers this. (this commit fixes also a TypeError in $syscallMunmap, which was hit by this test case)
kleisauke
force-pushed
the
mmap-msync-noderawfs
branch
from
6ac5c09 to
e9ceca1
Compare
|
Rebased on top of the master branch to resolve merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #10669 but then for NODERAWFS.