Skip to content

Add test for internal use of response files on windows #13673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2021
Merged

Add test for internal use of response files on windows #13673

merged 3 commits into from
Mar 17, 2021

Conversation

juj
Copy link
Collaborator

@juj juj commented Mar 16, 2021

No description provided.

@juj juj mentioned this pull request Mar 16, 2021
Merged
sbc100
sbc100 approved these changes Mar 17, 2021
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps give the PR a title that is meaningful and move the issue numbers to the description? How about: "Add test for internal use of response files on windows"?

@juj juj changed the title Add a test for #13661. See #13664 and #13465. Add test for internal use of response files on windows Mar 17, 2021
@juj juj enabled auto-merge (squash) March 17, 2021 08:17
@juj juj disabled auto-merge March 17, 2021 12:13
@juj juj merged commit 352385c into emscripten-core:main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juj @sbc100