Avoid setting _LIBCPP_HAS_CATOPEN in libcxx. NFC.
#13741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid unnecessary calls to the message catalog functions, which are currently not supported within Emscripten. Note that since musl v1.1.24 these functions are supported, but this would then add a dependency on `__map_file` (which is currently no-op).
sbc100
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid unnecessary calls to the messages catalog functions,
which are currently not supported within Emscripten.
Note that since musl v1.1.24 these functions are supported, see:
https://git.musl-libc.org/cgit/musl/commit?id=7590203c486d9002522019045d34ee3dee0a66f5
But this would then add a dependency on
__map_file(which iscurrently no-op).
The alternative would be to support message catalogs and the
__map_filefunction in the pending musl upgrade, but I'm notquite sure if this can be supported, see for details: c9bfee3.